integrity: signer and verifier implementation #15
+345
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4171-signer-verifier
branch
7 times, most recently
from
7dce61d to
679b87b
Compare
Pull Request Test Coverage Report for Build 19331947740Details
💛 - Coveralls |
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4171-signer-verifier
branch
2 times, most recently
from
b433eb8 to
809bb94
Compare
bigbes
requested changes
Nov 11, 2025
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4171-signer-verifier
branch
5 times, most recently
from
dc443ff to
7431a15
Compare
bigbes
approved these changes
Nov 12, 2025
Collaborator
|
Last thing: add tests for running without privkey, pubkey and both pubkey/privkey.
|
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4171-signer-verifier
branch
from
7431a15 to
09d6eef
Compare
oleg-jukovec
requested changes
Nov 12, 2025
Comment on lines
13
to
18
| Name() string | ||
| Verify(data []byte, signature []byte) error |
Collaborator
There was a problem hiding this comment.
Comments for the public API missed.
Comment on lines
+51
to
+52
| // Unmarshal implements interface. | ||
| func (m YAMLMarshaller) Unmarshal(data []byte, out any) error { |
Collaborator
There was a problem hiding this comment.
The call is not tested.
| func (m YAMLMarshaller) Marshal(data any) ([]byte, error) { | ||
| marshalled, err := yaml.Marshal(data) | ||
| if err != nil { | ||
| return []byte{}, ErrMarshall |
Collaborator
There was a problem hiding this comment.
Please, add a test for the error case.
Contributor
Author
There was a problem hiding this comment.
The only way to trigger an error here - pass a channel or function as data. But in this case panic is triggered. So, do we exactly need tests this error case?
| func (m YAMLMarshaller) Unmarshal(data []byte, out any) error { | ||
| err := yaml.Unmarshal(data, &out) | ||
| if err != nil { | ||
| return ErrUnmarshall |
Collaborator
There was a problem hiding this comment.
Please, add a test for the error case.
crypto/rsa_test.go
Outdated
Comment on lines
35
to
36
| fmt.Fprintf(os.Stderr, "Error generating RSA key: %s", err) | ||
| return |
Collaborator
There was a problem hiding this comment.
Suggested change
| fmt.Fprintf(os.Stderr, "Error generating RSA key: %s", err) | |
| return | |
| t.Fatalf(os.Stderr, "Error generating RSA key: %s", err) |
| func TestRsaOnlyPrivateKey(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| privateKey, err := rsa.GenerateKey(rand.Reader, 2048) |
Collaborator
There was a problem hiding this comment.
Or it could be:
Suggested change
| privateKey, err := rsa.GenerateKey(rand.Reader, 2048) | |
| privateKey, err := rsa.GenerateKey(rand.Reader, 2048) | |
| require.NoError(err) |
crypto/rsa_test.go
Outdated
Comment on lines
55
to
59
| privateKey, err := rsa.GenerateKey(rand.Reader, 2048) | ||
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "Error generating RSA key: %s", err) | ||
| return | ||
| } |
crypto/rsa_test.go
Outdated
Comment on lines
79
to
83
| privateKey, err := rsa.GenerateKey(rand.Reader, 2048) | ||
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "Error generating RSA key: %s", err) | ||
| return | ||
| } |
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4171-signer-verifier
branch
2 times, most recently
from
2f38999 to
1decf59
Compare
Closes #TNTP-4171
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4171-signer-verifier
branch
from
1decf59 to
1dce6f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #TNTP-4171